Skip to content

Commit

Permalink
replace ember-cli-release with release it
Browse files Browse the repository at this point in the history
  • Loading branch information
nvdk committed May 5, 2021
1 parent 59df033 commit cd5ffee
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 6,914 deletions.
6 changes: 2 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,7 @@ module.exports = function(environment) {

## Styling

If you use vanilla css the `ember-rdfa-editor` will add the default styles to your vendor css file.

However, if you are using `ember-cli-sass` the addon you need to import the addon styles yourself.
Ember-rdfa-editor requires users of the addon to import its SASS stylesheets. This has the advantage of easily allowing users to use and override variables to provide a custom theme for the editor. To support sass you must install `ember-cli-sass`. The stylesheets provided by ember-rdfa-editor can be imported with the following import statement:

```
@import "ember-rdfa-editor";
Expand All @@ -87,7 +85,7 @@ When installing this through `ember install` the addon will add the snippet abov

### Customisation

If you are using `ember-cli-sass` you can override the variables to provide a custom theme for the editor.
You can override the variables to provide a custom theme for the editor.
- [_s-colors.scss](https://github.com/lblod/ember-rdfa-editor/blob/master/app/styles/ember-rdfa-editor/_s-colors.scss): Collection of colors used.
- [_s-settings.scss](https://github.com/lblod/ember-rdfa-editor/blob/master/app/styles/ember-rdfa-editor/_s-settings.scss): General settings (spacing, font family, sizes and weights, media-queries)
- [_s-theme.scss](https://github.com/lblod/ember-rdfa-editor/blob/master/app/styles/ember-rdfa-editor/_s-theme.scss): Specific theme variables
Expand Down
40 changes: 0 additions & 40 deletions config/release.js

This file was deleted.

10 changes: 0 additions & 10 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,6 @@ module.exports = {
},

included() {
/**
* detect whether the parent app has sass installed. only import css if sass isn't installed
* this was inspired by https://github.com/cibernox/ember-power-select/blob/1d867972607784354cf819740e9e716db1cb923a/index.js
*/
let app = this._findHost();
let hasSass = !!app.registry.availablePlugins['ember-cli-sass'];
this._super.included.apply(this, arguments);
// Don't include the precompiled css file if the user uses a supported CSS preprocessor
if (!hasSass) {
app.import('vendor/ember-rdfa-editor.css');
}
},
};
22 changes: 15 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
"prepublishOnly": "ember ts:precompile",
"postpublish": "ember ts:clean",
"icons": "svg-symbols ./public/icons > ./public/say-symbolset.svg",
"prepare": "svg-symbols ./public/icons > ./public/say-symbolset.svg"
"prepare": "svg-symbols ./public/icons > ./public/say-symbolset.svg",
"release": "release-it"
},
"dependencies": {
"@ember/optional-features": "^1.3.0",
Expand Down Expand Up @@ -74,7 +75,6 @@
"ember-cli-dependency-checker": "^3.2.0",
"ember-cli-eslint": "^5.1.0",
"ember-cli-inject-live-reload": "^2.0.2",
"ember-cli-release": "^1.0.0-beta.2",
"ember-cli-sass": "^10.0.1",
"ember-cli-sri": "^2.1.1",
"ember-cli-typescript-blueprints": "^3.0.0",
Expand All @@ -98,6 +98,7 @@
"node-sass": "^4.13.1",
"npm-run-all": "^4.1.5",
"qunit-dom": "^1.2.0",
"release-it": "^14.6.1",
"sass": "^1.26.3",
"simple-git": "^1.10.0",
"svg-symbols": "^1.0.5",
Expand All @@ -118,11 +119,18 @@
},
"browserslist": [
"last 1 Chrome version",
"last 1 Android version",
"last 1 Firefox version",
"last 1 FirefoxAndroid version",
"last 1 Safari version",
"last 1 iOS version",
"last 1 Edge version"
]
],
"release-it": {
"github": {
"release": false
},
"npm": {
"publish": false
},
"git": {
"requireCleanWorkingDir": true
}
}
}
Loading

0 comments on commit cd5ffee

Please sign in to comment.