GN-4587: custom gap-cursor plugin #1027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a custom gap-cursor plugin containing several fixes compared to the original version:
click
handler has been replaced by amousedown
handler in order to intercept a click event earlierGapCursor
class have been fixedview.posAtCoords
.connected issues and PRs:
Solves the gap-cursor part of GN-4587
How to test/reproduce
isolating
attribute (like a table) at the start of the documentChallenges/uncertainties
resolvePosition
which resolves the position returned byview.posAtCoords
. Ideally, this function is not necessary, as it tries to circumvent the issue with wrong positions returned byview.posAtCoords
.Checks PR readiness