Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the dispatcher service inside the editor addon #124

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

nvdk
Copy link
Member

@nvdk nvdk commented Jul 1, 2021

it seems farfetched that the current code will evolve into an addon of its own,
it's more likely the dispatcher as it exists now will dissapear relatively soon.

this commit also make the loading of plugins a bit more defensive and
informative, if a plugin is configured in a profile but could not be loaded a
warning is printed

it seems farfetched that the current code will evolve into an addon of its own,
it's more likely the dispatcher as it exists now will dissapear relatively soon.

this commit also make the loading of plugins a bit more defensive and
informative, if a plugin is configured in a profile but could not be loaded a
warning is printed
@nvdk nvdk force-pushed the chore/remove-in-repo-addon-for-dispatcher branch from acc1504 to cf86b1b Compare July 1, 2021 15:02
@abeforgit abeforgit added the internal Version bumps, chores, tooling label Jul 1, 2021
@abeforgit abeforgit self-requested a review July 9, 2021 13:40
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you move the dispatcher to the app folder instead of to the addon folder with a re-export?

@nvdk
Copy link
Member Author

nvdk commented Jul 12, 2021

This is an old pain (which still exists and I didn't want to fix as part of this PR). The way we load the config atm only works from within the app folder.

@abeforgit
Copy link
Member

fair enough :)

@abeforgit abeforgit merged commit 1d5a6c3 into development Jul 13, 2021
@abeforgit abeforgit deleted the chore/remove-in-repo-addon-for-dispatcher branch July 13, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Version bumps, chores, tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants