Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/event bus #130

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Feature/event bus #130

merged 3 commits into from
Jul 12, 2021

Conversation

abeforgit
Copy link
Member

Implements a basic event bus to solve https://binnenland.atlassian.net/browse/GN-2808

This is mostly done so we can easily swap out the implementation later, and serves as a example on how we could implement a strongly typed event system. Currently listeners are notified in registration order.

@nvdk would like some input on where to best emit the contentChanged event to make sure we capture all changes, which is why this is a draft pr for now

abeforgit added 2 commits July 9, 2021 23:14

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@abeforgit abeforgit requested review from nvdk and RobbeDP July 9, 2021 22:03
@abeforgit abeforgit changed the base branch from master to development July 9, 2021 22:03
@abeforgit abeforgit added enhancement New feature or request bug Something isn't working labels Jul 9, 2021
@nvdk
Copy link
Member

nvdk commented Jul 12, 2021

@abeforgit I guess right now emiting in either updateRichNode or (perhaps better, because it debounces) in generateDiffEvents would be best for now. those should both be called after any action that might change content.

@abeforgit abeforgit marked this pull request as ready for review July 12, 2021 13:39
@abeforgit abeforgit merged commit 6a4dec3 into development Jul 12, 2021
@abeforgit abeforgit deleted the feature/event-bus branch July 12, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants