Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved set property command logic to the operation #152

Merged
merged 3 commits into from
Sep 2, 2021
Merged

moved set property command logic to the operation #152

merged 3 commits into from
Sep 2, 2021

Conversation

lagartoverde
Copy link
Contributor

No description provided.

@lagartoverde lagartoverde requested review from nvdk and abeforgit August 25, 2021 13:55
@abeforgit abeforgit added the internal Version bumps, chores, tooling label Aug 31, 2021
abeforgit
abeforgit approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.
Ideally the attributeoperation would become generic to handle any attribute, not just text attributes. But for me this is ok for now.

@abeforgit abeforgit merged commit aa5d62b into development Sep 2, 2021
@abeforgit abeforgit deleted the feature/set-property-as-operation branch September 2, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeforgit abeforgit abeforgit approved these changes

@nvdk nvdk Awaiting requested review from nvdk

Assignees
No one assigned
Labels
internal Version bumps, chores, tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lagartoverde @abeforgit