-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ember-appuniversum #171
Conversation
On the open questions:
|
@Dietr I'm guessing we will also need to update https://github.com/lblod/frontend-embeddable-notule-editor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the strong tag doens't look bold anymore in this branch. other than that I found no immediate issues.
Shouldn't the editor itself then also specify appuniversum as a peerdep? |
Add ember-appuniversum as dependency so we can remove the duplicate components in plugins over time.
Next steps:
Open questions: