Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use css variables #184

Merged
merged 12 commits into from
Nov 26, 2021
Merged

Use css variables #184

merged 12 commits into from
Nov 26, 2021

Conversation

Dietr
Copy link
Contributor

@Dietr Dietr commented Nov 19, 2021

Use css variables for ember appuniversum:

  • update ember-appuniversum
  • convert sass variables to css variables

Todo

  • update documentation
  • test styling implementation in GN and plugins

Breaking changes

  • all scss variables are replaced by css variables. Vendors or applications using these should convert these.
  • all scss toggles (paper, toolbar position, sidebar) have been replaced by component config settings. Vendors or applications using these will have to check if they still have the correct settings.

Questions/help needed

  • How do I correctly use the peerDepedencies for appuniversum? When I don't have appuniversum in devDepedencies it breaks the test.
  • We should find a way to generate the plain css on release to completely remove the sass dependency. Ideally also provide an option to not load this css when using sass. (See https://ember-power-select.com/docs/styles for an example approach)

@Dietr Dietr marked this pull request as ready for review November 23, 2021 13:31
@Dietr Dietr requested a review from nvdk November 23, 2021 13:31
@nvdk nvdk requested a review from abeforgit November 25, 2021 14:57
@abeforgit
Copy link
Member

abeforgit commented Nov 25, 2021

for dependencies:
we will always need appuniversum in devdeps, since devdeps are whats used for running the ember dummy app
when using the editor as an addon the devdeps wont be included anyway. There we can use peerdeps to give a signal to the host app that it needs to have appuniversum loaded

the way you set it up looks right to me

@abeforgit abeforgit added the enhancement New feature or request label Nov 26, 2021
@abeforgit abeforgit merged commit e310cc3 into development Nov 26, 2021
@abeforgit abeforgit deleted the feature/use-css-variables branch November 26, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants