-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gn 3152 create a debug component for the rdfa editor #206
Feature/gn 3152 create a debug component for the rdfa editor #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Main thing is the branch, we tend to branch our feature branches off of development and make PRs against that.
I can resolve the conflicts for you if you're not comfortable doing that
about this, notice ive changed the base branch of the PR already. Here's how to proceed:
* EDIT: just tried it, the conflicts are minor, so it can be good practice |
All code and testdata was copied from the dummy app to the addon. All things seem to work, apart from arguments to the debug component. Also rebase to development.
The normal arguments like rdfaEditorInit callback, toolbarOptions, and editorOptions are now supported (passed through) on the debug component.
These files made the drone builds fail
Component arguments didn't have the correct type yet. Added a TypeScript interface and added the type generics to the inherited Component class.
Removed the debug route and replaced the original index route with the new debug component. Also rebase to development.
fd62693
to
aa988e5
Compare
I tried reopening the branch to see if I could add more fixes to this thing, but I then forgot to switch to that branch and pushed to |
You should be able to use a debug component for the editor by using
<Rdfa::RdfaEditorWithDebug .../>
instead of the normal<Rdfa::RdfaEditor .../>
component with the same arguments. For example: