Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed support for @plugins on debug component #208

Merged

Conversation

benjay10
Copy link
Contributor

@benjay10 benjay10 commented Jan 27, 2022

Some plugins use @plugins on the component, which wasn't clear earlier. Support for this is a simple fix: just pass along the plugins argument.
We probably want release version 0.50.0-beta.6 for this, as other PRs are waiting for that version.

This commit and PR is part of a series of reverts, because this was first pushed onto the development branch.

“[BenJay10]” added 2 commits January 27, 2022 11:57
Apparently, plugins use @plugins on the component to supply an array of
strings that indicate the plugins to be used. This has to be passed
through on the debug component as well. My mistake, was also not in the
README at all (maybe because that mechanism is fased out?). This
warrants a release of 0.50.0-beta.6.
Now information about how to used the debug component and its block
content. Also minor improvements in the overall consistency of the file.
@benjay10 benjay10 requested a review from abeforgit January 27, 2022 17:58
@abeforgit abeforgit merged commit 9a9ac74 into development Jan 27, 2022
@abeforgit abeforgit deleted the bugfix/needed-support-for-plugins-on-debug-component branch January 27, 2022 22:49
@abeforgit abeforgit added the bug Something isn't working label Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants