Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list indentation #235

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Fix list indentation #235

merged 1 commit into from
Mar 11, 2022

Conversation

Dietr
Copy link
Contributor

@Dietr Dietr commented Mar 4, 2022

In some cases (GN: intro & outro text) the list indentation was not displayed correctly.

@Dietr Dietr requested a review from abeforgit March 4, 2022 09:25
@Dietr Dietr added the bug Something isn't working label Mar 4, 2022
@benjay10
Copy link
Contributor

benjay10 commented Mar 9, 2022

My apologies for reviewing, even when I'm not assigned.

The bug sure is fixed, bullet points follow logical indentation now, but I still have some remarks and not sure if this the correct time to solve them.

The bullet points seem to be negatively indented, they appear to much to the left (unless that is intentional). It looks a bit wonky, especially in overview components.
afbeelding
afbeelding

There is also no outlining of a virtual sheet of paper, in contrast to other parts of the application that use an editor. This is no big deal, but before these changes the text appeared all the way on the left of the screen, while now, with corrected padding, the text seems to float more in the center of the screen, which might be a bit confusing. It is as if there are irremovable spaces or tabs on the left.

Before this PR:
afbeelding

After this PR:
afbeelding

@nvdk
Copy link
Member

nvdk commented Mar 10, 2022

I think it's best to log these as separate bugs on the backlog, so we can already merge this fix.

@abeforgit abeforgit merged commit d3fb750 into development Mar 11, 2022
@abeforgit abeforgit deleted the bug/list-indentation branch March 11, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants