Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add embroider test scenarios to ember try #240

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

nvdk
Copy link
Member

@nvdk nvdk commented Mar 23, 2022

According to the embroider readme:

The best thing for all addons authors to do right now is to achieve the "Embroider Safe" support level. Follow the instructions in the @embroider/test-setup README to add the embroider-safe scenario to your ember-try config.

According to the embroider readme:
> The best thing for all addons authors to do right now is to achieve the "Embroider Safe" support level. Follow the instructions in the @embroider/test-setup README to add the embroider-safe scenario to your ember-try config.
@nvdk nvdk added internal Version bumps, chores, tooling prio:low labels Mar 23, 2022
@nvdk nvdk force-pushed the chore/add-embroider-try-scenario branch from ec54221 to e59cba4 Compare March 23, 2022 20:08
@nvdk
Copy link
Member Author

nvdk commented Mar 23, 2022

main things I've noticed:

  • embroider doesn't seem to like the way ix does it's exports/imports
  • some issues with how we set up crypt

@abeforgit abeforgit merged commit 9585bf5 into development Mar 23, 2022
@abeforgit abeforgit deleted the chore/add-embroider-try-scenario branch March 23, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Version bumps, chores, tooling prio:low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants