Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consice removing of RDFa type #253

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

benjay10
Copy link
Contributor

This version of the remove-type command does not create extra spaces on removing a type from the attribute of a DOM element. This is linked to the problems we found in lblod/besluit-publicatie-publish-service#8 where extra spaces in RDFa attributes (although legal) caused the RDFa parser to create triples with empty subjects.

This version does not create extra spaces on removing a type from the
attribute.
@benjay10 benjay10 added the bug Something isn't working label Apr 11, 2022
Copy link
Member

@nvdk nvdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a lot more readable as well 👍

Copy link
Contributor

@lagartoverde lagartoverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@benjay10 benjay10 merged commit 378b6a1 into development Apr 13, 2022
@benjay10 benjay10 deleted the bugfix/extra-spaces-on-changing-rdfa-types branch April 13, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants