Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug that selection was wrong when creating en empty list #258

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Fix bug that selection was wrong when creating en empty list #258

merged 2 commits into from
Apr 27, 2022

Conversation

lagartoverde
Copy link
Contributor

No description provided.

@lagartoverde lagartoverde requested review from nvdk and abeforgit April 20, 2022 14:12
@lagartoverde
Copy link
Contributor Author

Solves https://binnenland.atlassian.net/browse/GN-3392

@lagartoverde lagartoverde self-assigned this Apr 20, 2022
@lagartoverde lagartoverde added the bug Something isn't working label Apr 20, 2022
abeforgit
abeforgit requested changes Apr 22, 2022
View reviewed changes
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well, but breaks a few tests, please have a look

@abeforgit abeforgit merged commit 3ea8c12 into development Apr 27, 2022
@abeforgit abeforgit deleted the bugfix/selection-when-making-list branch April 27, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeforgit abeforgit abeforgit approved these changes

@nvdk nvdk Awaiting requested review from nvdk

Assignees

@lagartoverde lagartoverde

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lagartoverde @abeforgit