Fixed bug with making list at the end of the document #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeforgit
requested changes
Apr 22, 2022
nvdk
approved these changes
Apr 26, 2022
|
The walkFromNode function really walks (away) from the node. Aka there is an implicit assumption that the node we are walking from has already been yielded in the generator in a previous step. Therefore, returning the node we are walking from should actually always result in an infinite loop in the generator, and can never be the correct return value. |
abeforgit
reviewed
Apr 26, 2022
abeforgit
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://binnenland.atlassian.net/browse/GN-3395