Ember upgrade to v3.28 and others #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 27, 2022 16:37
Hoping that some weird problems reside.
added 6 commits
May 5, 2022 01:16
Some packages were moved back to an older version, and some missing styling is put back, to be reviewed in another PR. These changes got into this PR my mistake.
Most of these are done using a search and replace mechanism, a lot of them manually, and a few with --fix.
|
There is one more error that I havn't been able to fix. This requires more TypeScript knowledge. Hopefully @abeforgit or someone else can take a look at least. The project continues to be built, and runs correctly otherwise. |
added 2 commits
May 6, 2022 01:46
This reverts commit 6409843. Due to release-it-lerna-changelog not being updated be supported in release-it v15.
Our config type was badly defined, allowing string for the router location whereas only a select enum of strings was allowed
abeforgit
approved these changes
May 10, 2022
| @@ -1,4 +1,5 @@ | |||
| {{! template-lint-disable no-invalid-interactive }} | |||
| {{! template-lint-disable no-down-event-binding }} | |||
There was a problem hiding this comment.
Interesting that thats a lint rule, I agree with disabling it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically trying to upgrade packages that depend on an older version of embroider/macros which causes problems in frontend-gelinkt-notuleren. However, this turned into a complete Ember upgrade (using ember-cli-update).
Might be best to separate the embroider/macros fixes into their own separate branch.
There are still issues with this branch, which I could not figure out: