Feature/inline components #284
Conversation
…e renderspec interface
…ory attachment component
… the exported html
…nline-components-sample-plugin into feature/inline-components
This reverts commit 3aebd8e.
| if (componentSpec) { | ||
| const component = new ModelInlineComponent(componentSpec, props, state); | ||
| this.model.change( | ||
| (mutator) => { |
There was a problem hiding this comment.
the command seems to break when selection is not collapsed
tested using the sample-plugin
| controller: Controller; | ||
| } | ||
|
|
||
| export default class InlineComponent< |
There was a problem hiding this comment.
Even though it's logical, I'd move this file out of the components subfolder, since this folder has quite some significance in the ember build system
I have my reservations about making this a class to extend from as well
There's not that much wrong with it, but I do think it slightly breaks ember's tradition of not using inheritance
Id maybe prefer that the ember-component would recieve some kind of control interface as arguments, like we do with the controllers
It feels less magic to me than just suddenly having some extra methods on this
but I don't think it makes a big difference
There was a problem hiding this comment.
Modified in: fbefa1b
…spec as additional argument
|
Thanks for the comments! I have modified most of the code to take into account the suggestions. |
|
I have also introduced some modifications to shiftedVisually so it takes into account inline components. |
Adds support for the creation of inline interactive ember components which can be rendered inside the editor.