Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add recreate uuids plugin to prosemirror #556

Merged
merged 6 commits into from
Feb 1, 2023
Merged

add recreate uuids plugin to prosemirror #556

merged 6 commits into from
Feb 1, 2023

Conversation

lagartoverde
Copy link
Contributor

No description provided.

@lagartoverde lagartoverde self-assigned this Jan 24, 2023
elpoelma
elpoelma reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@elpoelma elpoelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the recreateUri and uriAttributes to the args of the ember-node utility functions?

@elpoelma elpoelma self-requested a review January 26, 2023 15:40
elpoelma
elpoelma reviewed Jan 26, 2023
View reviewed changes
Copy link
Contributor

@elpoelma elpoelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions:

  • This algorithm can maybe be extended to marks?
  • Maybe the nodes themselves can provide how to regenerate attributes? That way it is a bit more generic and can be easily extended to other type of attributes (not only uris).

@abeforgit
Copy link
Member

agree with elena's comments, good otherwise

@abeforgit abeforgit merged commit 7c06756 into master Feb 1, 2023
@abeforgit abeforgit deleted the feature/recreate-uuids-on-paste branch February 1, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpoelma elpoelma elpoelma left review comments

@abeforgit abeforgit Awaiting requested review from abeforgit

Assignees

@lagartoverde lagartoverde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lagartoverde @abeforgit @elpoelma