GN-4482: color-selector UX - make button bigger and more easily clickable #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeforgit
deleted the
embeddable-feedback-better-clickable-color-picker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Feedback embeddable:
The color picker has too small buttons to click (the round color buttons).
This is fixed in two ways:
connected issues and PRs:
https://binnenland.atlassian.net/browse/GN-4482 : Highlight color picker
How to test/reproduce
open the color picker (in the toolbar).
Before: had to perfectly click the circle.
Now: there is some leeway to click a button.
Note that clicking should always be what is show with a black circle and there should be no weird "bugs".
Challenges/uncertainties
To make the space to click bigger, a small "css hack" is used by using an element with
::before. This is a well known way to do this.The margins and placement of the element didn't seem to make a ton of sense (but definitely partially me not being a CSS wizard yet :) ). So I mostly got the values via trail&error.
The placement is also not centered, but more to the right, which I think is the typical way to support something like this, but I'm not sure.