Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] remember shell resizes between toggles #11

Open
laur89 opened this issue Oct 27, 2019 · 0 comments · May be fixed by #12
Open

[FR] remember shell resizes between toggles #11

laur89 opened this issue Oct 27, 2019 · 0 comments · May be fixed by #12

Comments

@laur89
Copy link

laur89 commented Oct 27, 2019

qt offers ratio configuration for setting height, but in addition to that I'd prefer it to also remember our ad-hoc resizes between toggles.

Current state:
a) shell is opened, height X
b) shell height is resized to Y
c) shell is toggled, hiding it
d) shell is toggled again, height X

To-be state:
a) shell is opened, height X
b) shell height is resized to Y
c) shell is toggled, hiding it
d) shell is toggled again, height remains at Y

Just fyi I'm working on it already, will be sending in a PR soon for consideration.
laur89 pushed a commit to laur89/i3-quickterm that referenced this issue Oct 27, 2019
remember shell resizes between toggles
93cce2a 
- make quickterm remember per-shell heigh ratio so our resizes would be
  persisted across toggles;
- add [-d,--daemon] option to start a daemon process managing stateful
  data (per-shell ratios) and shell toggling;

Fixes lbonn#11
laur89 pushed a commit to laur89/i3-quickterm that referenced this issue Oct 28, 2019
remember shell resizes between toggles
94e59b7 
- make quickterm remember per-shell heigh ratio so our resizes would be
  persisted across toggles;
- add [-d,--daemon] option to start a daemon process managing stateful
  data (per-shell ratios) and shell toggling;

Fixes lbonn#11
laur89 pushed a commit to laur89/i3-quickterm that referenced this issue Oct 28, 2019
remember shell resizes between toggles
0f034a8 
- make quickterm remember per-shell heigh ratio so our resizes would be
  persisted across toggles;
- add [-d,--daemon] option to start a daemon process managing stateful
  data (per-shell ratios) and shell toggling;

Fixes lbonn#11
@laur89 laur89 changed the title remember shell resizes between toggles [FR] remember shell resizes between toggles Oct 28, 2019
laur89 pushed a commit to laur89/i3-quickterm that referenced this issue Oct 28, 2019
remember shell resizes between toggles
bd220f0 
- make quickterm remember per-shell heigh ratio so our resizes would be
  persisted across toggles;
- add [-d,--daemon] option to start a daemon process managing stateful
  data (per-shell ratios) and shell toggling;
- in bring_up(), make sure container is first moved to scratchpad, and
  _then_ resized/positioned - otherwise behaviour is erratic in multi-mon
  setups;

Fixes lbonn#11
@laur89 laur89 linked a pull request Oct 28, 2019 that will close this issue
Open
laur89 pushed a commit to laur89/i3-quickterm that referenced this issue Oct 29, 2019
remember shell resizes between toggles
fd0228a 
- make quickterm remember per-shell heigh ratio so our resizes would be
  persisted across toggles;
- add [-d,--daemon] option to start a daemon process managing stateful
  data (per-shell ratios) and shell toggling;
- in bring_up(), make sure container is first moved to scratchpad, and
  _then_ resized/positioned - otherwise behaviour is erratic in multi-mon
  setups;

Fixes lbonn#11
laur89 pushed a commit to laur89/i3-quickterm that referenced this issue Nov 12, 2019
remember shell resizes between toggles
809e7ab 
- make quickterm remember per-shell heigh ratio so our resizes would be
  persisted across toggles;
- add [-d,--daemon] option to start a daemon process managing stateful
  data (per-shell ratios) and shell toggling;
- in bring_up(), make sure container is first moved to scratchpad, and
  _then_ resized/positioned - otherwise behaviour is erratic in multi-mon
  setups;

Fixes lbonn#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remember shell resizes between toggles laur89/i3-quickterm
1 participant
@laur89