Add configurable width and center position #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbonn
reviewed
Nov 24, 2023
| @@ -24,6 +24,7 @@ | |||
| "term": "urxvt", | |||
| "history": "{$HOME}/.cache/i3/i3-quickterm.order", | |||
| "ratio": 0.25, | |||
| "width": 0.5, | |||
There was a problem hiding this comment.
I would prefer keeping the existing defaults: "width": 1.0,.
Looking back into it, the ratio parameter is ugly and unhelpful, we can probably rename it to height at this point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to add a
widthconfiguration property. This property acts in exactly the same way asratio, but configures the width instead of the height.In addition, it also adds the
centerposition, allowing the terminal to be opened in the center instead of only at the top or the bottom of the screen.