[WIP] Touch support #143
Draft
[WIP] Touch support #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbonn
reviewed
Aug 25, 2024
| @@ -526,6 +526,100 @@ static const struct wl_keyboard_listener wayland_keyboard_listener = { | |||
| .repeat_info = wayland_keyboard_repeat_info, | |||
| }; | |||
|
|
|||
| static void wayland_touch_down(void *data, struct wl_touch *wl_touch, | |||
There was a problem hiding this comment.
The indentation is a bit inconsistent with the rest of the file.
Could you please run clang-format on the lines you've added?
| return; | ||
| } | ||
| int key = KEY_ENTER; | ||
| if (time - self->touches[id].start_time > 200) { |
There was a problem hiding this comment.
Maybe define this 200 as a constant with a proper name at the top of this function?
| } | ||
|
|
||
| static int32_t y_offset_to_line_offset(int32_t y_offset) { | ||
| static const int32_t line_height = 20; |
There was a problem hiding this comment.
So, this "20" is some kind of hard-coded sensitivity?
It is fine for now but maybe add a TODO comment like "TODO: make sensitivity parametrizable"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #122
This implements touch support in the following way:
-click-to-exitwould work, then this would be unnecessary)This is obviously not ideal, so I'd like some feedback on how a proper implementation should look like
Maybe programmable gesture support should be added? this would be useful for e.g. mode switching. I have no idea how the config for that should look though.