blackymax/update audio calling game #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackymax
requested review from
AlexeyTeterin,
Tonia-SE,
alexlatypov94,
Gurnick013 and
lbratkovskaya
alexlatypov94
approved these changes
Apr 14, 2021
lbratkovskaya
approved these changes
Apr 14, 2021
| if (audioCallingData.isEnd) { | ||
| return <FinishWindow />; | ||
| } | ||
| if (audioCallingData.isStart && !audioCallingData.isEnd) { | ||
| if (!isCountdown && audioCallingData.isStart && !audioCallingData.isEnd) { |
There was a problem hiding this comment.
Лишняя проверка: Если бы был isCountdown === true, мы бы уже вышли в первом return
| changeCountDown, | ||
| fetchExtraWords, | ||
| fetchGameWords, | ||
| } from '../../../store/actions/gamesActions'; |
There was a problem hiding this comment.
Порядок импортов: компоненты перед действиями
| const toggleResetEndGame = () => dispatch(resetEndGame()); | ||
| const startGame = (isStart: boolean) => dispatch(clickStartGame(isStart)); | ||
| const reset = () => dispatch(resetWordsToStartNewGame()); | ||
| const sendWords = (array: Array<{ word: IWord; correct: boolean }>) => | ||
| dispatch(addWordsToUserDictionary(array, userDictionary, userData)); | ||
|
|
||
| const unmountSound = () => { | ||
| const audioPromise = audio.play(); |
There was a problem hiding this comment.
Вот тут будет звучание напоследок. нельзя никак от него избавиться?
| import { Button } from '@material-ui/core'; | ||
| import GameAnswer from './GameAnswer'; | ||
| import GameExitBtn from '../../commonComponents/GameExitBtn/GameExitBtn'; | ||
| import GameQuestion from './GameQuestion'; | ||
| import GameTracker from '../../commonComponents/GameTracker/GameTracker'; | ||
| import VolumeRange from '../../commonComponents/VolumeRange/VolumeRange'; | ||
| import backendURL, { correctUrl, skipUrl, incorrectUrl, MAX_VOLUME } from '../../../constants'; | ||
| import backendURL, { correctUrl, incorrectUrl, MAX_VOLUME, skipUrl } from '../../../constants'; |
There was a problem hiding this comment.
Константы к константам, после экшнов
| @@ -20,6 +20,9 @@ const useStyles = makeStyles(() => | |||
| width: '50%', | |||
| fontSize: '24px', | |||
| marginLeft: '10px', | |||
| root: { | |||
There was a problem hiding this comment.
а так будет работать? у тебя сейчас root вложен в input...
There was a problem hiding this comment.
unusable class, deleted
AlexeyTeterin
approved these changes
Apr 14, 2021
Tonia-SE
approved these changes
Apr 14, 2021
Gurnick013
approved these changes
Apr 14, 2021
lbratkovskaya
force-pushed
the
blackymax/update_audio_calling_game
branch
from
0a586d5
to
79f6736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.