Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn isn't pulling in latest lbry-redux changes #1382

Closed
neb-b opened this issue Apr 24, 2018 · 9 comments
Closed

Yarn isn't pulling in latest lbry-redux changes #1382

neb-b opened this issue Apr 24, 2018 · 9 comments
Assignees
Labels
area: devops needs: exploration Solution unclear, needs research

Comments

@neb-b
Copy link

neb-b commented Apr 24, 2018

The Issue

Sometimes the yarn command isn't pulling in the latest lbry-redux changes. I've had to clear everything out and then use npm i to get it to work. Pretty sure it's something with yarn's global cache

Steps to Reproduce

  1. run yarn
  2. merge a PR into lbry-redux
  3. run yarn again
  4. see that it isn't up to date

Expected Behaviour

It should pull the latest files

@btzr-io
Copy link
Collaborator

btzr-io commented Apr 25, 2018

rm -r node_modules && yarn cache clean && yarn

@neb-b
Copy link
Author

neb-b commented Apr 25, 2018

Nice. We should probably just add this as a script. Maybe clean?

btzr-io added a commit that referenced this issue Apr 25, 2018
Fix for Yarn isn't pulling in latest lbry-redux changes #1382
@btzr-io
Copy link
Collaborator

btzr-io commented Apr 25, 2018

install:clean ?
I'm not good with names 🙃

@tzarebczan
Copy link
Contributor

Windows would be: del node_modules && yarn cache clean && yarn

@IGassmann
Copy link
Contributor

More information here yarnpkg/yarn#4722

@btzr-io
Copy link
Collaborator

btzr-io commented Apr 25, 2018

⚠️ If yarn is installing the wrong versions of any dependencies, run the following:

$yarn cache clean
$yarn

☝️ add the --pure-lockfile argument to yarn to ensure you install all dependencies exactly as specified in the current yarn.lock file.

paratii-portal/README.md#installing

@IGassmann IGassmann assigned neb-b and unassigned IGassmann Apr 30, 2018
@neb-b neb-b closed this as completed Apr 30, 2018
@tzarebczan
Copy link
Contributor

@seanyesmunt should we leave this open until we can find out a more automated process to run the commands? Or open a new issue for that?

@neb-b
Copy link
Author

neb-b commented May 1, 2018

Lets just keep this one open

@neb-b neb-b reopened this May 1, 2018
@tzarebczan tzarebczan added needs: exploration Solution unclear, needs research and removed needs: triage labels May 3, 2018
@neb-b
Copy link
Author

neb-b commented Jul 9, 2018

Closing this. We now clear the yarn cache for lbry-redux on every install.

@neb-b neb-b closed this as completed Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: devops needs: exploration Solution unclear, needs research
Projects
None yet
Development

No branches or pull requests

5 participants