Add last used collection to right click menu.

[Ruk33]

Fixes

Issue Number: #6205

What is the current behavior?

The last used collection is not displayed in the menu options.

What is the new behavior?

The last used collection is displayed in the menu options:

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting)
• Refactoring (no functional changes)
• Documentation changes
• Other - Please describe:

Please check all that apply to this PR using "x":

• I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
• I added a line describing my change to CHANGELOG.md
• I have checked that this PR does not introduce a breaking change
• This PR introduces breaking changes and I have provided a detailed explanation below

[jessopb]

Nice.
One thing - I found that after publishing a list, adding a claim to it does not update the recent item.

[Ruk33]

Thank you @jessopb I have sent a few changes for that.

[jessopb]

Hm, Can you just switch the recent claim in [ACTIONS.COLLECTION_PENDING]: (state, action) => { ?

[Ruk33]

@jessopb I just tested updating the last used collection by only using ACTIONS.COLLECTION_PENDING but it doesn't work as expected. Please let me know if this is what you meant by your comment.
Thanks!

[jessopb]

If lastUsed is just the uuid localId of the local collection, or the claimId of the published collection, then you can use a selector
collection: makeSelectCollectionForId(props.collectionId)(state), whenever you need the collection.
The only time that lastUsed needs to change from localId to claimId is when COLLECTION_PENDING happens.
There may be an edge case about deleting or unpublishing.

Does this make sense, or am I missing something? What part wasn't working?

[Ruk33]

Thank you @jessopb you were right, it's much cleaner now!

[jessopb]

We don't have a guarantee that collection.name is unique.

lbry-desktop/ui/redux/reducers/collections.js

Line 102 in ea7ed53

newPendingList[claimId] = Object.assign({}, newUnpublishedList[localId] || {});

Possibly here, we need to carry the old localId:

      if (localId) {
        // new publish
        newPendingList[claimId] = Object.assign({}, newUnpublishedList[localId] || {});
        newPendingList[claimId]['previousId'] = localId; // <--------
        delete newUnpublishedList[localId]; 
      } else {
      

Or maybe the collections reducer can keep an object mapping claimIds to localId that can just be looked up. The entry would be deleted after that pending claim is confirmed.