Handle non playable items in playlists. #7578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessopb
requested changes
May 6, 2022
| @@ -34,12 +34,38 @@ const select = (state, props) => { | |||
| const playingUri = selectPlayingUri(state); | |||
| const collectionId = urlParams.get(COLLECTIONS_CONSTS.COLLECTION_ID) || (playingUri && playingUri.collectionId); | |||
| const isMarkdownOrComment = playingUri && (playingUri.source === 'markdown' || playingUri.source === 'comment'); | |||
| const isClaimPlayable = (uri) => { | |||
There was a problem hiding this comment.
I think if we've gotten to videoViewer, we've should already know if it's playable.
There was a problem hiding this comment.
Some logic may also go in page/show/view.jsx which selects the first collection item and redirects there.
|
|
||
| let nextRecommendedUri; | ||
| let previousListUri; | ||
| if (collectionId) { | ||
| nextRecommendedUri = makeSelectNextUrlForCollectionAndUrl(collectionId, uri)(state); |
There was a problem hiding this comment.
I think we should do a makeSelectNextPlayableUrl.. etc. Keep the logic in the same place. What do you think?
…tNextPlayableUrlFromCollectionAndUrl
|
This is good. Will file a ticket for view progress being falsely 100% when file starts playing. |
jessopb
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Issue Number: #7575
What is the current behavior?
Only videos and audio can be added to playlists.
What is the new behavior?
All types of claims can be included in the playlists.
When played:
When played, all the items will be displayed in the claim list. The reason for this is to show the user the content of the list and not confuse the user as to what the list contains.
Other information
PR Checklist
Toggle...
What kind of change does this PR introduce?
Please check all that apply to this PR using "x":