Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewer position and shape in mobile mode #7677

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Fix viewer position and shape in mobile mode #7677

merged 1 commit into from
Aug 26, 2022

Conversation

jm-morani
Copy link
Contributor

Fixes

Issue Number:

What is the current behavior?

When the screen is narrow enough, the video is not render at the same location than the cover.
Because it's rather on the top of the window, the top of the video is hidden by the header.

What is the new behavior?

The video is played at the exact same location than the cover, and is fully visible.
As well, because that area has then no margin with the border of the window, I removed the rounded border (seems to already be a pattern).

Other information

This is a very minor change.

(On narrow window, it may look even better with an overlay scrollbar.)
Anyway, it may not be the best fix, but it solves my problem. Thank you for making lbry.

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

@jessopb
Copy link
Member

jessopb commented Aug 22, 2022

Thanks for the PR!
Can you tell me how you use lbry with narrow screen? Is it a specific device, or just using it windowed/tiled?

@jm-morani
Copy link
Contributor Author

I wrote "mobile" because that what is in the code. But, I actually use lbry on a laptop running debian bullseye and the i3 window manager.

Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jessopb jessopb merged commit 7a8a16c into lbryio:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants