Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 arch #111

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Add arm64 arch #111

merged 1 commit into from
Oct 28, 2023

Conversation

zerodivisi0n
Copy link
Contributor

Since arm64 architecture is quite popular nowadays (new Apple laptops, Raspberry Pi), I thinks that it's a good idea to have builds for it.

@zerodivisi0n
Copy link
Contributor Author

Unfortunately, this won't work for Docker images, which are built by a separate workflow.
GoReleaser supports Docker Images, so it is possible to switch building to it. I can do that, if you don't mind.

@lc
Copy link
Owner

lc commented Oct 28, 2023

Hey @zerodivisi0n,

This is a great idea! I do use arm64 personally, so not sure how I didn't think of having a build for it haha. I think not having it for Docker images is probably fine for now, unless you'd like to build that out.

@lc lc merged commit abf8b12 into lc:master Oct 28, 2023
@zerodivisi0n zerodivisi0n deleted the feature/arm64-arch branch October 28, 2023 22:51
@zerodivisi0n
Copy link
Contributor Author

Thanks for quick response, @lc!
I think I can add fixes for Docker images in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants