Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LcfiPlusProcessor: processorParameters are now a shared_ptr #24

Merged
merged 1 commit into from
Jul 2, 2017

Conversation

andresailer
Copy link
Collaborator

@andresailer andresailer commented Jun 30, 2017

As of iLCSoft/Marlin#16 the returned objects are now shared_ptrs

BEGINRELEASENOTES

  • Processor parameters are now a shared_ptr

ENDRELEASENOTES

@jstrube
Copy link
Contributor

jstrube commented Jul 1, 2017

Thank you.
It looks like this would need a newer version of gcc in travis.
I'll try to get around it this weekend.

@petricm
Copy link
Contributor

petricm commented Jul 1, 2017

No. This is due the the version of Marlin if was building against. If you restart the build it will work. The CI compiles against a nightly, if the whole of iLCSoft is not compiling a new nightly is not deployed... this has been circumvented by hand in the meantime.

@jstrube jstrube merged commit 8fb35c0 into lcfiplus:master Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants