Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dictionary generation on several platforms #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tmadlener
Copy link

@tmadlener tmadlener commented Nov 25, 2024

BEGINRELEASENOTES

  • Make sure to explicitly have the LCIO headers available for building against them.
  • Backport a patch that has been part of the spack recipe in key4hep-spack for 4 years now.

ENDRELEASENOTES

The first one is necessary for me to build LCFIPlus using iLCInstall on EL9 with gcc13.1 and ROOT v6.32/08. I cannot reprodce this with gcc13.2 and ROOT v6.32/06 on Ubuntu, so I am not yet sure what the actual problem is there, but in any case, it doesn't hurt.

The second one has been part of the LCFIPlus package in key4hep-spack for quite some time now. It was originally added by @andresailer, maybe he still has a recollection of how that came to be.


build log for that is fixed by the first commit

[  3%] generating: /afs/desy.de/project/ilcsoft/sw/x86_64_gcc131_el9/v02-03-04/LCFIPlus/v00-10-01/build/rootdict/dict.cc /afs/desy.de/project/ilcsoft/sw/x86_64_gcc131_el9/v02-03-04/LCFIPlus/v00-10-01/build/rootdict/dict_rdict.pcm
input_line_9:17:10: fatal error: 'EVENT/Cluster.h' file not found
#include "EVENT/Cluster.h"
         ^~~~~~~~~~~~~~~~~

Otherwise I run into problems with ROOT v6.32/08 on EL9 with gcc13. I
don't fully understand why I only run into this there.
This patch has been in the spack recipe in key4hep-spack for almost 5
years now, and ideally it should be brought back to the source.
@tmadlener
Copy link
Author

@suehara can this be merged as well and put into a new tag for LCFIPlus? Otherwise I will not be able to make a new iLCSoft release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant