Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logplayer-gui: Window title options #397

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Conversation

judfs
Copy link
Contributor

@judfs judfs commented Mar 7, 2023

Matching the new args added to lcm-spy by #389 :

  -t, --title [LABEL]    Display LABEL in the window title.
                         Defaults to the log filename.
  --title-url            Display the LCM URL in the window title.

The log filename is now displayed in the title if a different title isn't given.

If the file chooser gui is canceled, the app now closes. [I don't see a reason to remain running if there is no other way to select a log].

Example usages:

./lcm-java/lcm-logplayer-gui # Will exit if you hit cancel
./lcm-java/lcm-logplayer-gui loggylog.log 
./lcm-java/lcm-logplayer-gui loggylog.log --title "Alice"
./lcm-java/lcm-logplayer-gui loggylog.log -l 'udpm://239.255.76.67:8888?ttl=1' --title-url

judfs added 2 commits March 7, 2023 09:42
Also exit if the file picker gui is canceled.
Matching lcm-spy's new args:

  -t, --title [LABEL]    Display LABEL in the window title.
                         Defaults to the log filename.
  --title-url            Display the LCM URL in the window title.
@nosracd nosracd merged commit d96c962 into lcm-proj:master Mar 7, 2023
@nosracd nosracd mentioned this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants