Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog #426

Merged
merged 7 commits into from
Apr 19, 2023
Merged

Update changelog #426

merged 7 commits into from
Apr 19, 2023

Conversation

nosracd
Copy link
Contributor

@nosracd nosracd commented Mar 17, 2023

Marked as draft until the date can be filled in. Suggestions from all are welcome.

@nosracd
Copy link
Contributor Author

nosracd commented Mar 17, 2023

@tprk77 We're wrapping up on preparation for the 1.5.0 release. Is there anything (lua-related or otherwise) that you'd like to make it into the release?

@judfs
Copy link
Contributor

judfs commented Mar 23, 2023

https://github.com/lcm-proj/lcm/blob/dev-release-1.5/lcm-python/README is dated and features old maintainer email addresses.

Change log things:

Minimum requirement changes: i.e java 6 to 8 ~~ 2357c6a ~~ (edit: actually that commit isn't saying that)

@ihilt ihilt changed the base branch from dev-release-1.5 to master April 5, 2023 14:55
nosracd added 3 commits April 5, 2023 15:26
We'll use the main changelog (currently called NEWS) for python updates going forward.
The Python README contains outdated information or information that can be covered elsewhere.
@nosracd
Copy link
Contributor Author

nosracd commented Apr 5, 2023

Good points...

https://github.com/lcm-proj/lcm/blob/dev-release-1.5/lcm-python/README is dated and features old maintainer email addresses.

A lot of that information, in addition to being dated, doesn't seem useful anymore. For example, rather than listing maintainer email addresses it makes more sense to open an issue now that the project is hosted on GitHub. Because of that, 1f019ee just removes the file.

Change log things:

Minimum requirement changes: i.e java 6 to 8 ~~ 2357c6a ~~ (edit: actually that commit isn't saying that)

It's possible that LCM still builds on Java 6 but the oldest version any of our test platforms has packages for is 8 so 1f019ee raises the minimum required version to 8.

@tprk77
Copy link
Member

tprk77 commented Apr 10, 2023

Sorry I missed that ping before. If possible, I would take a couple days to look the the release.

NEWS.md Outdated Show resolved Hide resolved
@tprk77
Copy link
Member

tprk77 commented Apr 13, 2023

So improvements are great, and it's good to see this work going into LCM. I've found two things I wanted to ask about, and they are both regarding CMake:

  • In a couple of places there were changes to use pkg-config via pkg_check_modules. It's my understanding that CMake can use pkg-config for compatibility reasons, but it's kind of uncommon. Anyway, it's I think it's more idiomatic to use find_package. I could try to fix the issue with FindGLIB2, but I want to know what you think first.

  • In a couple of places there were changes to use link_libraries instead of target_link_libraries. According to the documentation, people should always prefer target_link_libraries even though it's more verbose. I can do a PR for this.

Should I go ahead and make these changes?

@tprk77
Copy link
Member

tprk77 commented Apr 15, 2023

Link: #442, #443

NEWS.md Outdated Show resolved Hide resolved
nosracd and others added 2 commits April 17, 2023 17:26
@nosracd nosracd marked this pull request as ready for review April 19, 2023 17:45
@nosracd nosracd merged commit 53e68e6 into lcm-proj:master Apr 19, 2023
@nosracd nosracd deleted the update/news branch April 19, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants