-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog #426
Update changelog #426
Conversation
@tprk77 We're wrapping up on preparation for the 1.5.0 release. Is there anything (lua-related or otherwise) that you'd like to make it into the release? |
https://github.com/lcm-proj/lcm/blob/dev-release-1.5/lcm-python/README is dated and features old maintainer email addresses. Change log things: Minimum requirement changes: i.e java 6 to 8 ~~ 2357c6a ~~ (edit: actually that commit isn't saying that) |
We'll use the main changelog (currently called NEWS) for python updates going forward. The Python README contains outdated information or information that can be covered elsewhere.
Good points...
A lot of that information, in addition to being dated, doesn't seem useful anymore. For example, rather than listing maintainer email addresses it makes more sense to open an issue now that the project is hosted on GitHub. Because of that, 1f019ee just removes the file.
It's possible that LCM still builds on Java 6 but the oldest version any of our test platforms has packages for is 8 so 1f019ee raises the minimum required version to 8. |
Sorry I missed that ping before. If possible, I would take a couple days to look the the release. |
So improvements are great, and it's good to see this work going into LCM. I've found two things I wanted to ask about, and they are both regarding CMake:
Should I go ahead and make these changes? |
Co-authored-by: Tim Perkins <code@tprk77.net>
Marked as draft until the date can be filled in. Suggestions from all are welcome.