-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exp in microseconds #229
Comments
See #230 |
@VincentSurelle the RCF clearly states that non-integer formats can be used:
In #171 we've decided to use decimal seconds to make things a bit more precise, we can make the DateTimeImmutable format a bit more configureable but for now you can simply do: $now = new DateTimeImmutable('@' . time());
$builder->issuedAt($now)
->expiresAt($now->modify('+15 minutes')); And builder will use integers.
Those libraries should be changed to adheres to what the RFC says 😄 |
With that said I'll be closing this as an invalid bug, please reopen it if you feel that we need to discuss things further 👍 |
Also see discussion here lcobucci/jwt#229
Hi guys,
For informations the 4.0 builder create the exp claim with microseconds which is not valid (see: https://tools.ietf.org/html/draft-ietf-oauth-json-web-token-32#page-6).
There should be only second.
It cause token validity troubles with some libraries.
I can a merge request if needed.
The text was updated successfully, but these errors were encountered: