Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove \Lcobucci\JWT\Signer\None #937

Closed
Slamdunk opened this issue Oct 11, 2022 · 1 comment
Closed

Remove \Lcobucci\JWT\Signer\None #937

Slamdunk opened this issue Oct 11, 2022 · 1 comment
Labels
BC-break Improvement
Milestone
5.0.0

Comments

@Slamdunk
Copy link
Collaborator

Slamdunk commented Oct 11, 2022 •
edited
Loading

While working on #936 I had the wish to remove the None signer entirely, so we can require all signatures to be non-empty-string.

Can we, please, so we throw away all possible misuses of that ancient specification?
@Ocramius Ocramius added this to the 5.0.0 milestone Oct 11, 2022
This was referenced Oct 11, 2022
Merged
Merged
@Slamdunk
Copy link
Collaborator Author

Closed by #939

@hamrak hamrak mentioned this issue Apr 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC-break Improvement
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@Slamdunk @Ocramius