-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove empty Signer, empty Key, empty Signature, empty string
s
#939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Oct 12, 2022
@lcobucci I'll rebase this PR and make it ready for review next week |
Slamdunk
commented
Nov 7, 2022
Slamdunk
changed the title
Remove empty Signer, empty Key and empty Signature
Remove empty Signer, empty Key, empty Signature, empty Nov 7, 2022
string
s
Slamdunk
commented
Nov 7, 2022
Ocramius
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most excellent! Thanks @Slamdunk!
lcobucci
reviewed
Nov 7, 2022
lcobucci
reviewed
Nov 7, 2022
lcobucci
reviewed
Nov 7, 2022
lcobucci
approved these changes
Nov 8, 2022
Thanks @Slamdunk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #937 for
v5
.This PR removes deprecated:
\Lcobucci\JWT\Signer\None
\Lcobucci\JWT\Signer\Key\InMemory::empty
\Lcobucci\JWT\Token\Signature::fromEmptyData
\Lcobucci\JWT\Configuration::forUnsecuredSigner
This PR is blocked by #936 and will be marked as ready if and when #936 is merged.
Until then, you can better browse the diff comparing this to #936: Slamdunk/jwt@non_empty_string...no_empty