Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty Signer, empty Key, empty Signature, empty strings #939

Merged
merged 9 commits into from
Nov 8, 2022

Conversation

Slamdunk
Copy link
Collaborator

@Slamdunk Slamdunk commented Oct 12, 2022

Addresses #937 for v5.

This PR removes deprecated:

  1. \Lcobucci\JWT\Signer\None
  2. \Lcobucci\JWT\Signer\Key\InMemory::empty
  3. \Lcobucci\JWT\Token\Signature::fromEmptyData
  4. and as a result, \Lcobucci\JWT\Configuration::forUnsecuredSigner

This PR is blocked by #936 and will be marked as ready if and when #936 is merged.

Until then, you can better browse the diff comparing this to #936: Slamdunk/jwt@non_empty_string...no_empty

[BC] REMOVED: Method Lcobucci\JWT\Configuration::forUnsecuredSigner() was removed
[BC] REMOVED: Class Lcobucci\JWT\Signer\None has been deleted
[BC] REMOVED: Method Lcobucci\JWT\Signer\Key\InMemory::empty() was removed

src/Decoder.php Show resolved Hide resolved
src/Signer/None.php Show resolved Hide resolved
@Slamdunk
Copy link
Collaborator Author

Slamdunk commented Nov 4, 2022

@lcobucci I'll rebase this PR and make it ready for review next week

@Slamdunk Slamdunk marked this pull request as ready for review November 7, 2022 11:21
@Slamdunk Slamdunk changed the title Remove empty Signer, empty Key and empty Signature Remove empty Signer, empty Key, empty Signature, empty strings Nov 7, 2022
@Slamdunk
Copy link
Collaborator Author

Slamdunk commented Nov 7, 2022

Sorry for not the cleanest way of doing it, but after the mega refactor of #967 it was tricky to get the two PR separated.

I've rebased this and merged #936 here, as well as expanding non-empty-string basically everywhere.

composer.json Show resolved Hide resolved
@Slamdunk Slamdunk requested review from Ocramius and lcobucci November 7, 2022 11:54
Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent! Thanks @Slamdunk!

src/Encoding/JoseEncoder.php Show resolved Hide resolved
@Ocramius Ocramius assigned Ocramius and lcobucci and unassigned Ocramius Nov 7, 2022
@lcobucci lcobucci merged commit 0aa6537 into lcobucci:5.0.x Nov 8, 2022
@Slamdunk Slamdunk deleted the no_empty branch November 8, 2022 09:14
@lcobucci
Copy link
Owner

lcobucci commented Nov 8, 2022

Thanks @Slamdunk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants