Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirement of core PHP extensions #1009

Closed
wants to merge 2 commits into from
Closed

Remove requirement of core PHP extensions #1009

wants to merge 2 commits into from

Conversation

cedric-anne
Copy link
Contributor

Since PHP 7.4, ext-hash is part of PHP core and cannot be disabled (see https://www.php.net/manual/en/hash.installation.php).
Since PHP 8.0, ext-json is part of PHP core and cannot be disabled (see https://www.php.net/manual/en/json.installation.php).

I think they could be removed from composer.json require section.

@cedric-anne
Copy link
Contributor Author

Lint job would be fixed by maglnet/ComposerRequireChecker#399.

@Ocramius
Copy link
Collaborator

Ocramius commented Apr 21, 2023 •
edited by lcobucci
Loading

@Ocramius Ocramius changed the base branch from 5.0.x to 5.1.x April 21, 2023 21:17
@Ocramius Ocramius added this to the 5.1.0 milestone Apr 21, 2023
@Ocramius Ocramius added Incomplete Waiting for Information Dependencies Pull requests that update a dependency file labels Apr 21, 2023
@Ocramius Ocramius self-assigned this Apr 22, 2023
Ocramius
Ocramius requested changes Apr 22, 2023
View reviewed changes
Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer.lock needs updating too

@cedric-anne cedric-anne requested a review from Ocramius April 22, 2023 11:11
Ocramius
Ocramius approved these changes Apr 22, 2023
View reviewed changes
Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cedric-anne!

@cedric-anne cedric-anne closed this by deleting the head repository Jul 11, 2023
@lcobucci lcobucci removed this from the 5.1.0 milestone Oct 31, 2023
lcobucci added a commit that referenced this pull request Nov 4, 2023
@lcobucci
Remove requirement of core PHP extensions
d7c6b1b 
This was raised by @cedric-anne but I didn't manage to merge it in time.

More info: #1009

Authored by: Cédric Anne
Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
@lcobucci lcobucci mentioned this pull request Nov 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Dependencies Pull requests that update a dependency file Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cedric-anne @Ocramius @lcobucci