Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8.3 #1030

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Support PHP 8.3 #1030

merged 1 commit into from
Oct 31, 2023

Conversation

javer
Copy link
Contributor

@javer javer commented Oct 30, 2023

This allows installation of the lib on PHP 8.3.

@Ocramius Ocramius requested a review from lcobucci October 30, 2023 21:29
@Ocramius Ocramius added the Dependencies Pull requests that update a dependency file label Oct 30, 2023
@Ocramius Ocramius added this to the 5.1.0 milestone Oct 30, 2023
Ocramius
Ocramius approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@Ocramius Ocramius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the mandatory checks require review by @lcobucci

@lcobucci
Copy link
Owner

LGTM, but the mandatory checks require review by @lcobucci

Not really, it requires a rebase only. I've tried to trigger it from the UI but it seems that @javer didn't allow changes from maintainers.

@Slamdunk
Copy link
Collaborator

@lcobucci I think Marco is talking about this:

image

A build is set as Required, but with this PR changes it doesn't exist anymore, because now the nightly build is on PHP 8.4

@lcobucci
Copy link
Owner

@lcobucci I think Marco is talking about this:

image

A build is set as Required, but with this PR changes it doesn't exist anymore, because now the nightly build is on PHP 8.4

Odd, the mobile app doesn't complain about that 😅

@lcobucci lcobucci merged commit f0031c0 into lcobucci:5.1.x Oct 31, 2023
19 checks passed
@lcobucci
Copy link
Owner

I've merged with admin powers, given the non-clear merge wouldn't cause issues, and released it.

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcobucci lcobucci lcobucci approved these changes

@Ocramius Ocramius Ocramius approved these changes

Assignees

@lcobucci lcobucci

Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@javer @lcobucci @Slamdunk @Ocramius