Improve CI configuration #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slamdunk
requested changes
Dec 30, 2020
|
Ah, I think the required checks need to be re-configured for this to be merged 😬 |
Slamdunk
requested changes
Dec 31, 2020
Slamdunk
approved these changes
Dec 31, 2020
|
These pipelines no longer exist:
These changes are OK, but require @lcobucci to change repo settings before merge |
|
Thanks folks! I'm taking a break from github and my laptop for a couple of days. Will take a look at it around the weekend. |
|
@t0mmy742 did you revert the cache optimisation on purpose? I thought the feedback was mostly about the templating. |
|
@lcobucci I missed something with |
It's alright, happens to everyone 😆 That's why the reflog is there for |
Bumping the minimum to ensure PHP 8.0 compatibility.
Avoiding caching the vendor directory and using the lock file to calculate the hash, according to the best practices of the action we're using. More info: https://github.com/shivammathur/setup-php#cache-composer-dependencies
Adding checks on PHP 8.1 as well.
lcobucci
approved these changes
Jan 5, 2021
|
@t0mmy742 thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple small things here:
action/cachefrom GitHub Actions. We were cachingvendordirectory, which is not really a good practice as mentioned here. Moreover, cache is now detecting changes ofcomposer.lock, since it used an hash of this file for generating the key.