Fix ecdsa key size validation #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
lcobucci
force-pushed
the
fix-ecdsa-key-size-validation
branch
from
ade69d9 to
ff9d6b3
Compare
Lines in OpenSSL error messages are split and we need to call `openssl_error_string()` multiple times to get all the occurred errors. More info: https://www.php.net/manual/en/function.openssl-error-string.php Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
The expected behaviour for key length verification between RSA and ECDSA algorithms are actually different. This shifts the responsibility to the base respective base implementations, simplifying the code a bit. Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
lcobucci
force-pushed
the
fix-ecdsa-key-size-validation
branch
from
ff9d6b3 to
367b7f4
Compare
|
😱 |
|
🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #704