Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Ecdsa\Sha512::expectedKeyLength() #909

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Clarify Ecdsa\Sha512::expectedKeyLength() #909

merged 1 commit into from
Sep 15, 2022

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Sep 14, 2022

@lcobucci I assume the 521 is unintended typo, right? 🤔

@lcobucci
Copy link
Owner

lcobucci commented Sep 14, 2022 •
edited
Loading

Nope, it's correct 😄
ES512 means ECDSA using P-521 and SHA-512, the key size is 521 (I got confused too 😅)

@enumag
Copy link
Contributor Author

enumag commented Sep 14, 2022

Oh, interesting. Might be worth a comment in the code?

@Ocramius
Copy link
Collaborator

@enumag you can adjust your patch to include that 👍

@enumag
Copy link
Contributor Author

enumag commented Sep 14, 2022

Will do tomorrow. :)

@enumag enumag changed the title Fix Ecdsa\Sha512::expectedKeyLength() Clarify Ecdsa\Sha512::expectedKeyLength() Sep 15, 2022
@enumag
Copy link
Contributor Author

enumag commented Sep 15, 2022

Done.

@Slamdunk Slamdunk added this to the 5.0.0 milestone Sep 15, 2022
@lcobucci lcobucci merged commit f9cc3fc into lcobucci:5.0.x Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Slamdunk Slamdunk Slamdunk approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@enumag @lcobucci @Ocramius @Slamdunk