-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow lcobucci/clock:^3.0
to be installed with lcobucci/jwt:^4
#986
Allow lcobucci/clock:^3.0
to be installed with lcobucci/jwt:^4
#986
Conversation
c6deec0
to
be16968
Compare
Not sure why
|
Is it me or this failure makes no sense? |
Perhaps |
Also: how is Box used on this project? 🤔 |
Nope... Is it a dependency of that tool? |
Also, what's going on with
|
Ah, we run it in a docker container: that may be a problem, if ownership isn't the same :-\ Since Git 1.25 or such, a lot of added security "noise" has been added to git, so running mixed container setups is very noisy. This can be mitigated by installing |
This line may needs be changed to |
About the BC checker stuff: should we ignore it? |
Yes and No: yes for this PR, but we should still fix its run. Even with BC-Check run fixed it will still fail here, so as |
That sucks, it's configured not to be required 😥 Merging... |
Thanks meanwhile, y'all! |
Done |
As per #985 discussions, allowing
lcobucci/clock:^3
inlcobucci/jwt:^4
will likely ease the upgrade path a bit