Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lcobucci/clock:^3.0 to be installed with lcobucci/jwt:^4 #986

Merged
merged 2 commits into from
Jan 2, 2023

Conversation

Ocramius
Copy link
Collaborator

As per #985 discussions, allowing lcobucci/clock:^3 in lcobucci/jwt:^4 will likely ease the upgrade path a bit

@Ocramius Ocramius added Improvement Dependencies Pull requests that update a dependency file labels Dec 19, 2022
@Ocramius Ocramius added this to the 4.3.0 milestone Dec 19, 2022
@Ocramius Ocramius force-pushed the feature/allow-newer-lcobucci-clock-installation branch from c6deec0 to be16968 Compare December 19, 2022 20:39
@Ocramius
Copy link
Collaborator Author

Not sure why normalize composer.json fails:

Box Requirements Checker
========================

> Using PHP 7.4.33
> PHP is using the following php.ini file:
  /etc/php/7.4/cli/php.ini

> Checking Box requirements:
  E......

                                                                                
Error: ] Your system is not ready to run the application.  

@lcobucci
Copy link
Owner

Is it me or this failure makes no sense?

@Ocramius
Copy link
Collaborator Author

Perhaps Box is running on a newer PHP version, or installing with --ignore-platform-reqs?

@Ocramius
Copy link
Collaborator Author

Also: how is Box used on this project? 🤔

@lcobucci
Copy link
Owner

Also: how is Box used on this project? 🤔

Nope... Is it a dependency of that tool?

@Slamdunk
Copy link
Collaborator

Also, what's going on with Backwards compatibility check?

fatal: detected dubious ownership in repository at '/github/workspace'
To add an exception for this directory, call:

	git config --global --add safe.directory /github/workspace

@Ocramius
Copy link
Collaborator Author

Ocramius commented Dec 20, 2022

Ah, we run it in a docker container: that may be a problem, if ownership isn't the same :-\

Since Git 1.25 or such, a lot of added security "noise" has been added to git, so running mixed container setups is very noisy.

This can be mitigated by installing roave/backward-compatibility-check as its own tool in its own directory 🤔

@smoench
Copy link

smoench commented Jan 2, 2023

composer-normalize has dropped support for PHP 7.4. in the latest release. The github workflow runs with PHP 7.4 and doesn't use a fixed version here.

This line may needs be changed to tools: composer:v2, composer-normalize:2.8.3, composer-require-checker, composer-unused.

@Slamdunk
Copy link
Collaborator

Slamdunk commented Jan 2, 2023

Thank you @smoench, I've locked the 2.28.3 (not 2.8.3 😉) and indeed now the build goes green again.

@Ocramius
Copy link
Collaborator Author

Ocramius commented Jan 2, 2023

About the BC checker stuff: should we ignore it?

@Slamdunk
Copy link
Collaborator

Slamdunk commented Jan 2, 2023

Yes and No: yes for this PR, but we should still fix its run.

Even with BC-Check run fixed it will still fail here, so as Collaborators we can't merge this, we don't have enough permissions.
Need to wait @lcobucci

@lcobucci
Copy link
Owner

lcobucci commented Jan 2, 2023

Yes and No: yes for this PR, but we should still fix its run.

Even with BC-Check run fixed it will still fail here, so as Collaborators we can't merge this, we don't have enough permissions.
Need to wait @lcobucci

That sucks, it's configured not to be required 😥

Merging...

@lcobucci lcobucci merged commit 4d7de2f into 4.3.x Jan 2, 2023
@lcobucci lcobucci deleted the feature/allow-newer-lcobucci-clock-installation branch January 2, 2023 13:28
@Slamdunk
Copy link
Collaborator

Slamdunk commented Jan 2, 2023

Thanks @lcobucci: can I close 4.3.0 milestone so it gets released?

@Ocramius
Copy link
Collaborator Author

Ocramius commented Jan 2, 2023

Thanks meanwhile, y'all!

@lcobucci
Copy link
Owner

lcobucci commented Jan 2, 2023

Thanks @lcobucci: can I close 4.3.0 milestone so it gets released?

Feel free to handle it, my connection is a bit meh

@Ocramius
Copy link
Collaborator Author

Ocramius commented Jan 2, 2023

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants