Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape unescape improvements #1902

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Escape unescape improvements #1902

merged 3 commits into from
Jun 13, 2023

Conversation

Shaikh-Ubaid
Copy link
Collaborator

@Shaikh-Ubaid Shaikh-Ubaid commented Jun 13, 2023 •
edited
Loading

This PR extracts the essential changes from #1885. That PR (#1885) needs to be rebased after merging/completion of this PR.

@Shaikh-Ubaid Shaikh-Ubaid mentioned this pull request Jun 13, 2023
Draft
@Shaikh-Ubaid
Copy link
Collaborator Author

Ready.

@Shaikh-Ubaid Shaikh-Ubaid requested a review from certik June 13, 2023 19:46
certik
certik approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these are all good changes.

@certik certik merged commit b729d70 into lcompilers:main Jun 13, 2023
@Shaikh-Ubaid Shaikh-Ubaid deleted the escape_unescape_improvements branch June 13, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shaikh-Ubaid @certik