Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASRVerify: Require signed integer array dimensions #1903

Merged
merged 1 commit into from
Jun 13, 2023
Merged

ASRVerify: Require signed integer array dimensions #1903

merged 1 commit into from
Jun 13, 2023

Conversation

Shaikh-Ubaid
Copy link
Collaborator

fixes #1899

@Shaikh-Ubaid
Copy link
Collaborator Author

@certik How do we test this?

@certik
Copy link
Contributor

certik commented Jun 13, 2023

@certik How do we test this?

Right now just by hand. We should eventually test all of these ASR verify checks systematically, one way to do that is via the MASR tool that @rebcabin is developing. We can setup randomized tests and ensure that if the ASR is outside of the "spec" that verify() always fails, and if it is inside the "spec" that it always succeeds.

We'll focus on this after we deliver LFortran/LPython to beta. Right now just best effort solid ASR verify() is all we can do.

@Shaikh-Ubaid Shaikh-Ubaid merged commit d20a094 into lcompilers:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ASR verify: check that only signed integers are allowed in dimensions
2 participants
@Shaikh-Ubaid @certik