Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename m_global_scope and fix typo #2322

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Rename m_global_scope and fix typo #2322

merged 3 commits into from
Sep 13, 2023

Conversation

Shaikh-Ubaid
Copy link
Collaborator

@Shaikh-Ubaid Shaikh-Ubaid mentioned this pull request Sep 12, 2023
Merged
@Shaikh-Ubaid Shaikh-Ubaid changed the title Rename m_global_scope and fix typo Rename m_global_scope and fix typo Sep 12, 2023
certik
certik approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine.

@Shaikh-Ubaid Shaikh-Ubaid merged commit 8b60246 into lcompilers:main Sep 13, 2023
12 checks passed
@Shaikh-Ubaid Shaikh-Ubaid deleted the rename_and_fix_typo branch September 13, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shaikh-Ubaid @certik