Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable llvm tests for symbolics #2430

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

Thirumalai-Shaktivel
Copy link
Collaborator

No description provided.

@Thirumalai-Shaktivel
Copy link
Collaborator Author

Ready!

@@ -1267,6 +1267,7 @@ namespace LCompilers {
break;
}
case (ASR::ttypeType::CPtr) : {
a_kind = 8;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, we used a_kind = 4, but now I set 8 to be default, this is required for Symbolic as we use i64 pointer for CPtr.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought CPtr doesn't have a kind?

Copy link
Collaborator Author

@Thirumalai-Shaktivel Thirumalai-Shaktivel Nov 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the list[CPtr] uses a_kind to decide malloc_size.
Is this a bug?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the changes and the changes do work in the correct direction. If we could know whether a_kind would be required or not for list[CPtr], the PR can be finished accordingly .

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @certik
Could you clarify Thirumalai's comment here? I think this is close to completion once we have an idea for the same.

@certik certik marked this pull request as ready for review November 29, 2023 18:00
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good for now, it enables several tests and the changes are small and seem clean. I do not understand the design of a kind for CPtr, but that's a separate question. So I think we can merge this.

@certik certik merged commit 20b249e into lcompilers:main Nov 29, 2023
13 checks passed
@Thirumalai-Shaktivel Thirumalai-Shaktivel deleted the symbolic_02 branch December 1, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants