Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor (asr): rename symbol StructType to Struct and ttype Struct to StructType #2740

Merged
merged 14 commits into from
Jun 20, 2024
Merged

refactor (asr): rename symbol StructType to Struct and ttype Struct to StructType #2740

merged 14 commits into from
Jun 20, 2024

Conversation

kmr-srbh
Copy link
Contributor

Rename symbol StructType to Struct and ttype Struct to StructType.

@kmr-srbh @Thirumalai-Shaktivel
Undo change in comment
9fc429a 
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
@kmr-srbh @Thirumalai-Shaktivel
Undo minor case-based renaming
b3beefa 
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
Thirumalai-Shaktivel
Thirumalai-Shaktivel reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@Thirumalai-Shaktivel Thirumalai-Shaktivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to merge, thank you!

kmr-srbh and others added 8 commits June 19, 2024 22:18
@kmr-srbh @Thirumalai-Shaktivel
Undo renaming in messages
36f2c83 
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
@kmr-srbh @Thirumalai-Shaktivel
Undo renaming in messages
c2c5fdf 
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
@kmr-srbh @Thirumalai-Shaktivel
Undo renaming in message
a639914 
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
@kmr-srbh
dev: fix typo
2c036f7
@kmr-srbh
tests: update test references
980b999
@kmr-srbh @Thirumalai-Shaktivel
revert changes related to asr.h
d7e50b7 
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
@kmr-srbh
dev: revert changes related to asr.h
a201563
@kmr-srbh
revert unnecesary changes in wasm_instructions_visitor.py
c71e9aa
certik
certik reviewed Jun 20, 2024
View reviewed changes
src/libasr/pass/pass_utils.h
}

void visit_Function(const ASR::Function_t &x) {
if( ASRUtils::is_intrinsic_optimization<ASR::Function_t>(&x) ) {
return ;
}
PassUtils::PassVisitor<Struct>::visit_Function(x);
PassUtils::PassVisitor<StructType>::visit_Function(x);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be just a Struct, since it is a template parameter.

certik
certik approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. I left a minor comment. I am going to merge it now, to unblock Tanay.

@certik certik merged commit ecd26e2 into lcompilers:main Jun 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@Thirumalai-Shaktivel Thirumalai-Shaktivel Awaiting requested review from Thirumalai-Shaktivel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmr-srbh @certik @Thirumalai-Shaktivel @tanay-man