Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select compiler image closes #6 #5

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Conversation

HolgerHuo
Copy link

Description

Related issues / Pull Requests

Contributor Agreement

@wzf03 wzf03 mentioned this pull request Oct 5, 2024
@wzf03
Copy link

wzf03 commented Oct 5, 2024

#6

@leavelet
Copy link
Member

leavelet commented Oct 5, 2024

这些镜像在哪里构建?24.10好理解,22.10是啥意思?要不只保留年份?

@HolgerHuo
Copy link
Author

这些镜像在哪里构建?

目前没有ci,底包(特别是旧版本)应该无须更新,可以打包完直接上传。

24.10好理解,22.10是啥意思?要不只保留年份?

const match = image.match(/:([0-9]+)\.[0-9]+/)
上游使用了这样的匹配规则,保留年份需要也修改一下,我猜测应该是打包时的月份。

@leavelet
Copy link
Member

leavelet commented Oct 5, 2024

这些镜像在哪里构建?

目前没有ci,底包(特别是旧版本)应该无须更新,可以打包完直接上传。

24.10好理解,22.10是啥意思?要不只保留年份?

const match = image.match(/:([0-9]+)\.[0-9]+/)
上游使用了这样的匹配规则,保留年份需要也修改一下,我猜测应该是打包时的月份。

上游的规则要不就按上游来?底包可能需要改Dockerfile,增加构建脚本

@HolgerHuo
Copy link
Author

上游的规则要不就按上游来?
好的。感觉上游不会对这些模块再有更新了,更新的应该在pro版里

底包可能需要改Dockerfile,增加构建脚本

是指deploy.sh? ci直接部署到服务器上?目前有打包好字体的版本吗

@wzf03
Copy link

wzf03 commented Oct 5, 2024

上游使用了这样的匹配规则,保留年份需要也修改一下,我猜测应该是打包时的月份。

或许只是一个小的标识符,来防止tag冲突的,比如2024.0、2024.1这样递增下去的,没有啥意义

@HolgerHuo
Copy link
Author

或许只是一个小的标识符,来防止tag冲突的,比如2024.0、2024.1这样递增下去的,没有啥意义

确实,应该是这样,https://github.com/overleaf/overleaf/wiki/Server-Pro:-Sandboxed-Compiles 示例是从1开始的

@HolgerHuo HolgerHuo linked an issue Oct 5, 2024 that may be closed by this pull request
@HolgerHuo HolgerHuo removed a link to an issue Oct 5, 2024
@HolgerHuo HolgerHuo changed the title feat: select texlive image feat: select compiler image closes #6 Oct 5, 2024
@HolgerHuo HolgerHuo merged commit 12545ec into main Oct 5, 2024
@HolgerHuo HolgerHuo deleted the feat-texlive-image branch October 14, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants