Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnify_client doesn't respond to incmwfact #195

Closed
teranex opened this issue May 6, 2016 · 2 comments
Closed

Magnify_client doesn't respond to incmwfact #195

teranex opened this issue May 6, 2016 · 2 comments

Comments

@teranex
Copy link

teranex commented May 6, 2016

When a client is set to magnify using lain.util.magnify_client it's size doesn't grow or shrink as does a client in the default magnify layout, when using modkey+h and modkey+l. However when disabling magnify and reenabling it again the size of the client is different. It would be very useful if you could actually see it grow/shrink.

@lcpz
Copy link
Owner

lcpz commented May 8, 2016

The function magnify_client sets the client to float and resizes it.

When you later call awful.client.incwfact, this one only works on non-floating clients, that's why you don't see the lain-magnified client changing its geometry.

Plus, magnify_client calls awful.tag.getmwfact, and that's why toggling it you see the geometry finally changing.

In order to make magnify_client behave like magnifier, update to latest commit and use lain.util.mc() after incmwfact:

awful.key({ modkey,           }, "l",
function ()
    awful.tag.incmwfact( 0.05)
    lain.util.mc()
end),

awful.key({ modkey,           }, "h",
function ()
    awful.tag.incmwfact(-0.05)
    lain.util.mc()
end),

@lcpz lcpz closed this as completed May 8, 2016
@teranex
Copy link
Author

teranex commented May 8, 2016

This works indeed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants