Release v1.4

[kinke]

Beta 1:

• Generate release page
  • Add description about recent sanitizers work
• Upload src archive
• Upload MSVC archives
• Upload Linux x86_64 archive
• Upload OSX archive
• Upload native Android/ARM archive
• Update https://github.com/ldc-developers/ldc-developers.github.io
• Forum posts. incl. details about new build environments (LDC-LLVM v4.0.1; Ubuntu 14.04 with GCC 6.3; Visual Studio 2017 v15.0...) Edit: already on GitHub release page

[JohanEngelen]

It'd be very nice to get compiler-rt / sanitizers into the LDC-LLVM package. I just tried: it requires clang to be in the package too... I can try and ask for the compiler-rt build to not require clang, but I don't know how long it will take people to fix it, if at all. Adding clang to LDC-LLVM would increase the source download and the build time, but otherwise has no negative effects. Is that agreeable?

[kinke]

You mentioned that Weka builds it in a standalone fashion. If that's not easily feasible for us, adding clang as additional submodule would be acceptable IMO.

[JohanEngelen]

For libFuzzer, extra manual commands are needed, even when including clang/compiler-rt in the source archive argh :(

This is what I have for Weka:

# Get LLVM compiler-rt source and build it
wget -q http://releases.llvm.org/$LLVM_VERSION/compiler-rt-$LLVM_VERSION.src.tar.xz
tar -xf compiler-rt-*
cd compiler-rt-*
mkdir build && cd build
cmake -DCMAKE_BUILD_TYPE=Release ..
make -j32 install
cd ../..
rm -rf compiler-rt-*

# Build libFuzzer (depends on <sanitizer/coverage_interface.h>)
cd llvm*
cd lib/Fuzzer
# In LLVM 4.0 build.sh assumes clang, so we can't use it. Fixed in LLVM 5.0. Build manually for now.
CXX=gcc
CXX="${CXX:-clang}"
for f in ./*.cpp; do
  $CXX -g -O2 -fno-omit-frame-pointer -std=c++11 $f -c &
done
wait
rm -f libFuzzer.a
ar ru libFuzzer.a Fuzzer*.o
rm -f Fuzzer*.o
$SUDO cp libFuzzer.a /usr/local/lib/
cd ../../..

We would have to add -DLLVM_CONFIG_PATH=... for compiler-rt, and also some extra include path flags when compiling libFuzzer.

So it's not so hard, but all this is tedious ofcourse. Hope to have time later tonight to try.

[JohanEngelen]

(also when compiler-rt is not built as part of LLVM, the LDC cmake script won't find the libraries, so we will have to copy them manually afterwards)

[kinke]

Damn tedious, I see. Love the -j32 though. ;)

[JohanEngelen]

@kinke Did you ever try to build ASan/libFuzzer on Windows? From what I can tell, it "should" be possible.

[kinke]

Nope, but then I only switched to v4.0.1 a couple of weeks ago and am now mainly focusing on LLVM 5.0 (and its LLD, which should finally make -link-internally at least theoretically work for all targets, and possibly significantly simplify LTO). Considering the obstacles you mentioned, I'm glad I didn't go down that rabbit hole. ;)

[JohanEngelen]

Added brief description of the sanitizer options to the release notes.
(I want to write two articles about it, but it will take a little while)

[kinke]

Thanks, looks really good.

[JohanEngelen]

I've added a "1b-build-llvm-runtime.sh" script to ldc2-packing. Works on my machine (OSX) (LDC CMake finds the libraries and copies them, yay). Hope it works on Linux too.

[kinke]

Thanks, doesn't look too bad (just slightly wondering about the wait and whether it causes problems when run inside a non-interactive Docker container), I'll try it out on Linux tomorrow and if found working, redo the Docker image and Linux x64 archive.

[kinke]

@JohanEngelen: The LLVM libs can be flawlessly built on Linux x64; I had to comment out the tampering with CXX though (it's set to g++-6 in the Docker container, clang isn't available). What was your issue with it on Mac?

[JohanEngelen]

@kinke Nice. CXX is not set to anything on Mac. (i forgot the bash syntax for "if not defined, define it as ...", something with a ? i think) Ah, now I see I committed "clang++", this was not intended. I actually intended it to be "g++" !

[redstar]

@JohanEngelen Syntax is: export XXX=${CXX:-defaultvalue}

[kinke]

On Ubuntu 16.04 [native platform on which I tested a tentative release build], -fsanitize=address works fine out of the box, but fuzzer fails to link due to a C++ runtime mismatch, so I guess -stdlib=libc++ is required.