-Woverloaded-virtual triggers

[mihails-strasuns]

Have noticed while repackaging last release there there are lot of warnings printed like this:

[  9%] Building CXX object CMakeFiles/LDCShared.dir/gen/typinf.cpp.o
In file included from /build/ldc/src/ldc/gen/typinf.cpp:32:0:
/build/ldc/src/ldc/dmd2/module.h:57:18: warning: 'virtual void Package::semantic(Scope*)' was hidden [-Woverloaded-virtual]
     virtual void semantic(Scope *sc) { }
                  ^
/build/ldc/src/ldc/dmd2/module.h:145:10: warning:   by 'void Module::semantic()' [-Woverloaded-virtual]
     void semantic();    // semantic analysis

It looks like effectively a false positive because parameter sets are different but you may want to do something with flooding the compilation log :)

[redstar]

Yes, it is a false positive. Root cause is the DMD frontend source which is compiled with almost no warnings enabled. In contrast, the genuine LDC parts are compiled with -Wall -Wextra. I think I will disable some more warnings....

[dnadlinger]

I'd prefer to fix these bugs once and for all in the upstream source, though. Then again, since the frontend is going to be switched to D eventually…

[dnadlinger]

What I originally planned to do was to add in pairs warning enabling/disabling pragmas around the DMD includes in all the LDC source files.

[redstar]

I also thought to do this....

[mihails-strasuns]

Is there any point in keeping this open?

[dnadlinger]

Not really.