Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldc-0.13.0-beta1-src/gen/cl_helpers.cpp:62: possible missing call to va_end ? #695

Closed
dcb314 opened this issue Aug 7, 2014 · 4 comments
Closed

Comments

@dcb314
Copy link

dcb314 commented Aug 7, 2014

BUILD/ldc-0.13.0-beta1-src/gen/cl_helpers.cpp:62]: (error) va_list 'va' was opened but not closed by va_end().

    va_start(va, p);
    while ((p = va_arg(va, bool*))) {
        locations.push_back(p);
    }
}
redstar added a commit that referenced this issue Aug 8, 2014
@redstar
Copy link
Member

redstar commented Aug 8, 2014

This affects all ldc versions including master. It is fixed now. Which tool/compiler produced this error message?

@dcb314
Copy link
Author

dcb314 commented Aug 8, 2014

Which tool/compiler produced this error message?

cppcheck from sourceforge, although you'll have to get their
most recent trunk development version from svn,
not their latest release.

@redstar
Copy link
Member

redstar commented Aug 8, 2014

Ok, I'll have a look at this tool.

@redstar redstar closed this as completed Aug 8, 2014
@dnadlinger
Copy link
Member

Fortunately, va_end is a no-op on most platforms, so it shouldn't have actually lead to any issues (even though the code is still wrong as per the spec).

redstar pushed a commit that referenced this issue Sep 27, 2014
additional Unicode win api, +SwapBuffers, +ChoosePixelFormat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants